- 
                Notifications
    
You must be signed in to change notification settings  - Fork 81
 
MAINT: avoid warnings because of symlinks pointing outside repo #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fa269c5    to
    ebe7411      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another solution would be to create the symlinks in the test code. This is simpler, but should we add a note in the test somewhere stating that these test files are not present in the sdist?
ebe7411    to
    5915072      
    Compare
  
    
          
 I prefer this, both because it's simpler and because I regularly use test packages directly rather than via a   | 
    
| 
           Added the note in the test case itself, that is indeed useful.  | 
    
| 
           CI failure is unrelated, looks like a change in Meson master:  | 
    
| 
           mesonbuild/meson#12194 probably.  | 
    
          
 Most likely. That patch changes the format of the introspection data used by meson-python. So far meson-python assumes that the introspection data uses native path separators. Now, some data uses native path separators, and some uses POSIX path separators independently of the platform. For supporting Meson version before and after the change, meson-python will need to normalize all paths read from introspection data.  | 
    
| 
           I opened gh-778 to keep track of the new failure. This PR is ready to merge I'd say.  | 
    
5915072    to
    e344701      
    Compare
  
    e344701    to
    d95885d      
    Compare
  
    | 
           I moved the note in a place where it makes more sense.  | 
    
Follows up on #728 (comment) and gh-745.